-
Notifications
You must be signed in to change notification settings - Fork 939
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Discovery Fixes #5050
Merged
Merged
Discovery Fixes #5050
Changes from 4 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
a16ad72
connect to dv5 bootnodes
nisdas c5181e2
Merge refs/heads/master into dv5Fixes
prylabs-bulldozer[bot] da4c2c1
fix test
nisdas 06e3db0
Merge branch 'dv5Fixes' of https://github.com/prysmaticlabs/geth-shar…
nisdas 488dea7
change polling period
nisdas 8a1b27b
ignore
nisdas 45d76a3
Update beacon-chain/p2p/service.go
terencechain f8b010c
Update beacon-chain/p2p/service_test.go
terencechain 1fddf82
Merge refs/heads/master into dv5Fixes
prylabs-bulldozer[bot] f3f9e5b
Merge refs/heads/master into dv5Fixes
prylabs-bulldozer[bot] 6e19766
Merge refs/heads/master into dv5Fixes
prylabs-bulldozer[bot] d9e73ce
Merge refs/heads/master into dv5Fixes
prylabs-bulldozer[bot] 119a77d
Merge refs/heads/master into dv5Fixes
prylabs-bulldozer[bot] 6de0dd1
fix test
nisdas 8c3373a
Merge branch 'dv5Fixes' of https://github.com/prysmaticlabs/geth-shar…
nisdas 28e03c6
Merge refs/heads/master into dv5Fixes
prylabs-bulldozer[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this formal enough to be defined in beacon's
config.go
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not really, most of these params are only useful in the
p2p
package. This is just a baseline on how often to poll our local table for new peers. I think they are fine living here in this package.