Add in Slasher Metrics #5060
Merged
Add in Slasher Metrics #5060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
0xKiwi
reviewed
Mar 10, 2020
| surroundedVotesDetected = promauto.NewCounter(prometheus.CounterOpts{ | ||
| Name: "surrounded_votes_detected", | ||
| Help: "The # of surrounded slashable events detected", | ||
| }) |
There was a problem hiding this comment.
Should we add a "rejected by beacon node pool" metric?
There was a problem hiding this comment.
Will add in the beacon node side
0xKiwi
reviewed
Mar 10, 2020
Co-Authored-By: Ivan Martinez <ivanthegreatdev@gmail.com>
terencechain
requested changes
Mar 10, 2020
| "github.com/prometheus/client_golang/prometheus/promauto" | ||
| ) | ||
|
|
||
| var ( |
There was a problem hiding this comment.
can we follow prometheus's metric and label naming conventions? (ie. end with _total for most of these)
terencechain
approved these changes
Mar 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves #5056.
Description
Write a summary of the changes you are making
This PR adds important metrics for us to understand the behavior of our running slasher in production.
In slasher
In the beacon node