-
Notifications
You must be signed in to change notification settings - Fork 940
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add in Slasher Metrics #5060
Merged
Merged
Add in Slasher Metrics #5060
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
4dd658d
added in slasher metrics
rauljordan ade6dde
Merge branch 'master' into slasher-metrics
rauljordan 9c80eb6
add in prom bolt metrics for slasher
rauljordan 11484c7
Merge branch 'slasher-metrics' of github.com:prysmaticlabs/prysm into…
rauljordan 68e4242
imports
rauljordan 78da3c2
include all metrics
rauljordan 5b66002
no dup bolt collector
rauljordan 815eaa8
Update slasher/detection/attestations/spanner.go
rauljordan 7adc664
naming best practices for prom, thx Terence
rauljordan 8915a98
Merge branch 'slasher-metrics' of github.com:prysmaticlabs/prysm into…
rauljordan File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,45 @@ | ||
package slashings | ||
|
||
import ( | ||
"github.com/prometheus/client_golang/prometheus" | ||
"github.com/prometheus/client_golang/prometheus/promauto" | ||
) | ||
|
||
var ( | ||
numPendingAttesterSlashings = promauto.NewGauge( | ||
prometheus.GaugeOpts{ | ||
Name: "num_pending_attester_slashings", | ||
Help: "Number of pending attester slashings in the pool", | ||
}, | ||
) | ||
numAttesterSlashingsIncluded = promauto.NewCounter( | ||
prometheus.CounterOpts{ | ||
Name: "attester_slashings_included_total", | ||
Help: "Number of attester slashings included in blocks", | ||
}, | ||
) | ||
attesterSlashingReattempts = promauto.NewCounter( | ||
prometheus.CounterOpts{ | ||
Name: "attester_slashing_reattempts_total", | ||
Help: "Times an attester slashing for an already slashed validator is received", | ||
}, | ||
) | ||
numPendingProposerSlashings = promauto.NewGauge( | ||
prometheus.GaugeOpts{ | ||
Name: "num_pending_proposer_slashings", | ||
Help: "Number of pending proposer slashings in the pool", | ||
}, | ||
) | ||
numProposerSlashingsIncluded = promauto.NewCounter( | ||
prometheus.CounterOpts{ | ||
Name: "proposer_slashings_included_total", | ||
Help: "Number of proposer slashings included in blocks", | ||
}, | ||
) | ||
proposerSlashingReattempts = promauto.NewCounter( | ||
prometheus.CounterOpts{ | ||
Name: "proposer_slashing_reattempts_total", | ||
Help: "Times a proposer slashing for an already slashed validator is received", | ||
}, | ||
) | ||
) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
package beaconclient | ||
|
||
import ( | ||
"github.com/prometheus/client_golang/prometheus" | ||
"github.com/prometheus/client_golang/prometheus/promauto" | ||
) | ||
|
||
var ( | ||
slasherNumAttestationsReceived = promauto.NewCounter(prometheus.CounterOpts{ | ||
Name: "slasher_attestations_received_total", | ||
Help: "The # of attestations received by slasher", | ||
}) | ||
) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
package detection | ||
|
||
import ( | ||
"github.com/prometheus/client_golang/prometheus" | ||
"github.com/prometheus/client_golang/prometheus/promauto" | ||
) | ||
|
||
var ( | ||
doubleProposalsDetected = promauto.NewCounter(prometheus.CounterOpts{ | ||
Name: "double_proposals_detected_total", | ||
Help: "The # of double propose slashable events detected", | ||
}) | ||
doubleVotesDetected = promauto.NewCounter(prometheus.CounterOpts{ | ||
Name: "double_votes_detected_total", | ||
Help: "The # of double vote slashable events detected", | ||
}) | ||
surroundingVotesDetected = promauto.NewCounter(prometheus.CounterOpts{ | ||
Name: "surrounding_votes_detected_total", | ||
Help: "The # of surrounding slashable events detected", | ||
}) | ||
surroundedVotesDetected = promauto.NewCounter(prometheus.CounterOpts{ | ||
Name: "surrounded_votes_detected_total", | ||
Help: "The # of surrounded slashable events detected", | ||
}) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should we add a "rejected by beacon node pool" metric? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Will add in the beacon node side |
||
) |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we follow prometheus's metric and label naming conventions? (ie. end with
_total
for most of these)https://prometheus.io/docs/practices/naming/