-
Notifications
You must be signed in to change notification settings - Fork 988
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add in Slasher Metrics #5060
Add in Slasher Metrics #5060
Conversation
surroundedVotesDetected = promauto.NewCounter(prometheus.CounterOpts{ | ||
Name: "surrounded_votes_detected", | ||
Help: "The # of surrounded slashable events detected", | ||
}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add a "rejected by beacon node pool" metric?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will add in the beacon node side
Co-Authored-By: Ivan Martinez <ivanthegreatdev@gmail.com>
"github.com/prometheus/client_golang/prometheus/promauto" | ||
) | ||
|
||
var ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we follow prometheus's metric and label naming conventions? (ie. end with _total
for most of these)
This resolves #5056.
Description
Write a summary of the changes you are making
This PR adds important metrics for us to understand the behavior of our running slasher in production.
In slasher
In the beacon node