Update to v0.12 #5614
Merged
Update to v0.12 #5614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5614 +/- ##
==========================================
- Coverage 59.87% 59.86% -0.01%
==========================================
Files 323 323
Lines 27516 27550 +34
==========================================
+ Hits 16474 16493 +19
- Misses 8813 8815 +2
- Partials 2229 2242 +13 |
nisdas
requested review from
farazdagi,
rauljordan and
0xKiwi
and removed request for
farazdagi,
rauljordan and
0xKiwi
|
Converted this to draft so even less likely someone review and merge it |
* rem outdated tests * remove redundant * benches passing Co-authored-by: prylabs-bulldozer[bot] <58059840+prylabs-bulldozer[bot]@users.noreply.github.com>
0xKiwi
reviewed
Jun 9, 2020
* Remove subscribeDynamic which was not dynamic anymore * Add deployed Onyx contract Co-authored-by: rauljordan <raul@prysmaticlabs.com>
* rem outdated tests * remove redundant * refactor and cleanup * comment * terence's review * Update beacon-chain/rpc/validator/attester.go * Update beacon-chain/rpc/validator/attester.go * Update beacon-chain/rpc/validator/attester.go * Update beacon-chain/rpc/validator/attester.go * benches passing * fix up attester test Co-authored-by: rauljordan <raul@prysmaticlabs.com> Co-authored-by: prylabs-bulldozer[bot] <58059840+prylabs-bulldozer[bot]@users.noreply.github.com> Co-authored-by: terence tsao <terence@prysmaticlabs.com>
Co-authored-by: Ivan Martinez <ivanthegreatdev@gmail.com>
Merged
* ivan's feedback * remove config method
prestonvanloon
approved these changes
Jun 9, 2020
terencechain
approved these changes
Jun 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do NotMerge:go fmtand updates validator files #5995from Topaz (Skipped)