Consistent BLS function inputs #5969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5969 +/- ##
==========================================
+ Coverage 59.48% 59.60% +0.12%
==========================================
Files 319 318 -1
Lines 26945 26786 -159
==========================================
- Hits 16027 15965 -62
+ Misses 8739 8653 -86
+ Partials 2179 2168 -11 |
rauljordan
approved these changes
May 25, 2020
rauljordan
added a commit
that referenced
this pull request
May 26, 2020
* Unskip beacon chain spec tests * Fixed test and update configs * Unskip ssz tests * Exepected error from skip bls verify test * Consider minimal * Fixed broken tests after changing curve * Fix TestComputeStateRoot_OK test * Remove Warning on Using Default Mainnet Config (#5983) * removed mainnet warn * Consistent BLS function inputs (#5969) * Make function input consistent * Change back * Typo * Fixed test Co-authored-by: prylabs-bulldozer[bot] <58059840+prylabs-bulldozer[bot]@users.noreply.github.com> * Cherry pick ddb861a * fix test setup * fix more tests * debugging * bls tests pass Co-authored-by: Raul Jordan <raul@prysmaticlabs.com> Co-authored-by: prylabs-bulldozer[bot] <58059840+prylabs-bulldozer[bot]@users.noreply.github.com> Co-authored-by: nisdas <nishdas93@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only cosmetic changes. This PR standardize (ie order, naming) of the inputs for BLS functions. It makes all the function inputs consistent across the library.