Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Warning on Using Default Mainnet Config #5983

Merged
merged 1 commit into from May 25, 2020

Conversation

rauljordan
Copy link
Contributor

No tracking issue. This PR removes the log WARN: using default mainnet config from beacon nodes, as we should only be warning a user if they are using minimal

@rauljordan rauljordan requested a review from a team as a code owner May 25, 2020 19:21
@rauljordan rauljordan self-assigned this May 25, 2020
@codecov
Copy link

codecov bot commented May 25, 2020

Codecov Report

Merging #5983 into master will decrease coverage by 0.23%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #5983      +/-   ##
==========================================
- Coverage   59.87%   59.63%   -0.24%     
==========================================
  Files         319      319              
  Lines       27175    26927     -248     
==========================================
- Hits        16270    16057     -213     
+ Misses       8711     8686      -25     
+ Partials     2194     2184      -10     

@prylabs-bulldozer prylabs-bulldozer bot merged commit 497307d into master May 25, 2020
@delete-merged-branch delete-merged-branch bot deleted the no-warn-on-config branch May 25, 2020 19:43
rauljordan added a commit that referenced this pull request May 26, 2020
* Unskip beacon chain spec tests

* Fixed test and update configs

* Unskip ssz tests

* Exepected error from skip bls verify test

* Consider minimal

* Fixed broken tests after changing curve

* Fix TestComputeStateRoot_OK test

* Remove Warning on Using Default Mainnet Config (#5983)

* removed mainnet warn

* Consistent BLS function inputs (#5969)

* Make function input consistent

* Change back

* Typo

* Fixed test

Co-authored-by: prylabs-bulldozer[bot] <58059840+prylabs-bulldozer[bot]@users.noreply.github.com>

* Cherry pick ddb861a

* fix test setup

* fix more tests

* debugging

* bls tests pass

Co-authored-by: Raul Jordan <raul@prysmaticlabs.com>
Co-authored-by: prylabs-bulldozer[bot] <58059840+prylabs-bulldozer[bot]@users.noreply.github.com>
Co-authored-by: nisdas <nishdas93@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants