Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unskip spec tests #5965

Merged
merged 17 commits into from
May 26, 2020
Merged

Unskip spec tests #5965

merged 17 commits into from
May 26, 2020

Conversation

terencechain
Copy link
Member

@terencechain terencechain commented May 23, 2020 •
edited by rauljordan

Unskipped tests

  • Mainnet tests
  • Minimal tests
  • SSZ tag tests

Current failing tests:

  • Attester slashing spec TestAttesterSlashingMainnet See: Attester Slashing Spec Test Has Bad Signatures ethereum/consensus-specs#1841
  • Minimal reward and penalty spec tests failing
  • Minimal eth1 vote spec size spec test failing
  • Sync unit tests failing due to diff aggregator index
  • Block processing unit tests failing due to diff proposer index
  • State transition unit tests failing due to diff aggregator index
  • Eth1 data proposer unit tests failing due to min votes per period changed from 2->4
  • TestAggregateVerifyYaml/aggregate_verify_valid fails

@terencechain terencechain requested a review from a team as a code owner May 23, 2020 03:36
@terencechain terencechain requested review from rauljordan, shayzluf and nisdas and removed request for a team May 23, 2020 03:36
@terencechain terencechain added the Blocked Blocked by research or external factors label May 23, 2020
@terencechain
Copy link
Member Author

Working on Minimal reward and penalty tests failing

@terencechain terencechain changed the title Unskip beacon chain spec tests Unskip spec tests May 23, 2020
@nisdas
Copy link
Member

nisdas commented May 23, 2020

@terencechain we will need to disable signature verification for a few tests according to the bls setting from ethereum/consensus-specs#1841

terencechain and others added 6 commits May 23, 2020 08:40
@terencechain
Exepected error from skip bls verify test
67e5727
@terencechain
Consider minimal
aaf789a
@terencechain
Fixed broken tests after changing curve
ff08786
@terencechain
Fix TestComputeStateRoot_OK test
17b05fd
@rauljordan
Remove Warning on Using Default Mainnet Config (#5983)
497307d 
* removed mainnet warn
@terencechain @prylabs-bulldozer
Consistent BLS function inputs (#5969)
3b65cb6 
* Make function input consistent

* Change back

* Typo

* Fixed test

Co-authored-by: prylabs-bulldozer[bot] <58059840+prylabs-bulldozer[bot]@users.noreply.github.com>
@terencechain terencechain mentioned this pull request May 25, 2020
Merged
@terencechain terencechain force-pushed the unskip-beacon-chain-spec-tests branch from 871167a to 2ef91f0 Compare May 26, 2020 05:22
@terencechain terencechain added Help Wanted Extra attention is needed v0.12 and removed Blocked Blocked by research or external factors labels May 26, 2020
@terencechain terencechain force-pushed the unskip-beacon-chain-spec-tests branch 3 times, most recently from 51de389 to 1380d1f Compare May 26, 2020 20:21
@terencechain terencechain added Ready For Review A pull request ready for code review and removed Help Wanted Extra attention is needed labels May 26, 2020
@rauljordan rauljordan merged commit 08edcf0 into v0.12 May 26, 2020
@rauljordan rauljordan deleted the unskip-beacon-chain-spec-tests branch May 26, 2020 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rauljordan rauljordan rauljordan approved these changes

@shayzluf shayzluf Awaiting requested review from shayzluf

@nisdas nisdas Awaiting requested review from nisdas

@prestonvanloon prestonvanloon Awaiting requested review from prestonvanloon

Assignees
No one assigned
Labels
Ready For Review A pull request ready for code review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@terencechain @nisdas @rauljordan