Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiarch docker containers #12428

Merged
merged 81 commits into from
Sep 28, 2023
Merged

Multiarch docker containers #12428

merged 81 commits into from
Sep 28, 2023

Conversation

prestonvanloon
Copy link
Member

@prestonvanloon prestonvanloon commented May 18, 2023

What type of PR is this?

Feature

What does this PR do? Why is it needed?

This uses OCI manifest format (previously docker v2).

Features:

  • Images are now available in OCI format
  • Images include /bin/bash
  • /bin/bash works on the images
  • Images are available for amd64 and arm64 as a multiarch index.
  • All previous image uploads are supported (Will be completed in follow up PR)

Which issues(s) does this PR fix?

Fixes #4900

Other notes for review

Depends on #12135, review and merge that first for clean diff.

A follow up PR will provide the following changes:

prestonvanloon and others added 30 commits March 15, 2023 15:58
@prestonvanloon
Copy link
Member Author

Still blocked by bazel-contrib/rules_oci#292

@prestonvanloon prestonvanloon marked this pull request as ready for review September 27, 2023 20:35
@prestonvanloon prestonvanloon requested a review from a team as a code owner September 27, 2023 20:35
@prestonvanloon
Copy link
Member Author

With e948da3, I think we can say we are unblocked and merge.

If build times increase significantly then we may have to revert this PR. The flag removed only matters when fetching dependencies where it would hit an internal endpoint before reaching the external network. In theory, it shouldn't be much different but possibly an issue.

I propose that we review this PR and merge targeting gcr.io/prylabs-dev/prysm for one release cycle, test further, then remove the old rules_docker and use the canonical gcr.io image URLs / names.

@prestonvanloon prestonvanloon added Ready For Review A pull request ready for code review OK to merge labels Sep 27, 2023
Copy link
Contributor

@james-prysm james-prysm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the explanations

@prylabs-bulldozer prylabs-bulldozer bot merged commit 02ee689 into develop Sep 28, 2023
16 of 17 checks passed
@prylabs-bulldozer prylabs-bulldozer bot deleted the multiarch-containers branch September 28, 2023 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready For Review A pull request ready for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multi-Arch docker images
3 participants