Allow Nil Return from DB Methods #3247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rauljordan
requested review from
prestonvanloon,
terencechain,
0xKiwi,
nisdas and
shayzluf
terencechain
previously approved these changes
Aug 20, 2019
terencechain
approved these changes
Aug 20, 2019
Codecov Report
@@ Coverage Diff @@
## master #3247 +/- ##
==========================================
+ Coverage 46.3% 50.32% +4.01%
==========================================
Files 142 138 -4
Lines 10063 9846 -217
==========================================
+ Hits 4660 4955 +295
+ Misses 4600 4093 -507
+ Partials 803 798 -5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No tracking issue - the current DB refactor had a bug that would not return a nil element if none was found.