Add /p2p page #3391
Merged
Add /p2p page #3391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3391 +/- ##
===========================================
+ Coverage 2.68% 39.98% +37.29%
===========================================
Files 24 184 +160
Lines 967 12563 +11596
===========================================
+ Hits 26 5023 +4997
- Misses 940 6618 +5678
- Partials 1 922 +921 |
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #3391 +/- ##
===========================================
+ Coverage 2.68% 39.98% +37.29%
===========================================
Files 24 184 +160
Lines 967 12563 +11596
===========================================
+ Hits 26 5023 +4997
- Misses 940 6618 +5678
- Partials 1 922 +921 |
terencechain
reviewed
Sep 3, 2019
| func (s *Service) InfoHandler(w http.ResponseWriter, _ *http.Request) { | ||
| buf := new(bytes.Buffer) | ||
| if _, err := fmt.Fprintf(buf, `bootnode=%s | ||
| self=%s |
There was a problem hiding this comment.
is it just my browser? or this looks messed up
There was a problem hiding this comment.
using ` formats it exactly how you have it. If i add tabs/spacing here, then it would be tabbed/spaced in the rendering.
terencechain
approved these changes
Sep 3, 2019
rauljordan
approved these changes
Sep 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds new
/p2ppage served on the monitoring port. Try accessinghttp://localhost:8080/p2p.Example: