Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept a filepath for bootnode ENR address #3422

Merged
merged 2 commits into from
Sep 9, 2019
Merged

Conversation

prestonvanloon
Copy link
Member

Testnet related infra code

terencechain
terencechain previously approved these changes Sep 9, 2019
0xKiwi
0xKiwi previously approved these changes Sep 9, 2019
@codecov
Copy link

codecov bot commented Sep 9, 2019

Codecov Report

Merging #3422 into master will decrease coverage by 49.3%.
The diff coverage is 28.57%.

@@            Coverage Diff             @@
##           master   #3422       +/-   ##
==========================================
- Coverage   56.42%   7.12%   -49.31%     
==========================================
  Files         135     134        -1     
  Lines        8457    8340      -117     
==========================================
- Hits         4772     594     -4178     
- Misses       2984    7667     +4683     
+ Partials      701      79      -622

1 similar comment
@codecov
Copy link

codecov bot commented Sep 9, 2019

Codecov Report

Merging #3422 into master will decrease coverage by 49.3%.
The diff coverage is 28.57%.

@@            Coverage Diff             @@
##           master   #3422       +/-   ##
==========================================
- Coverage   56.42%   7.12%   -49.31%     
==========================================
  Files         135     134        -1     
  Lines        8457    8340      -117     
==========================================
- Hits         4772     594     -4178     
- Misses       2984    7667     +4683     
+ Partials      701      79      -622

@prestonvanloon prestonvanloon merged commit 4dad28d into master Sep 9, 2019
@delete-merged-branch delete-merged-branch bot deleted the read-enr-from-file branch September 9, 2019 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants