Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kubernetes - Part 2 of ?? #401

Merged
merged 5 commits into from
Aug 14, 2018
Merged

Conversation

prestonvanloon
Copy link
Member

  • Added some more details to the README.
  • Added some configs.
  • Added better host IP address choice for p2p.

@codecov
Copy link

codecov bot commented Aug 14, 2018

Codecov Report

Merging #401 into master will increase coverage by 0.05%.
The diff coverage is 75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #401      +/-   ##
==========================================
+ Coverage    53.5%   53.56%   +0.05%     
==========================================
  Files          31       31              
  Lines        2493     2500       +7     
==========================================
+ Hits         1334     1339       +5     
- Misses        998      999       +1     
- Partials      161      162       +1
Impacted Files Coverage Δ
shared/p2p/discovery.go 92.3% <100%> (+1.39%) ⬆️
shared/p2p/options.go 57.14% <50%> (-6.5%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f56c43...ca25521. Read the comment docs.

Copy link
Member

@terencechain terencechain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just tried it out. It looks good!

@rauljordan rauljordan merged commit 9c76455 into prysmaticlabs:master Aug 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants