Do not panic if initial sync fails #4477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nisdas
previously approved these changes
Jan 10, 2020
Codecov Report
@@ Coverage Diff @@
## master #4477 +/- ##
=========================================
Coverage ? 42.51%
=========================================
Files ? 193
Lines ? 12842
Branches ? 0
=========================================
Hits ? 5460
Misses ? 6459
Partials ? 923 |
|
Additional fixes for handling sync issues:
|
rauljordan
approved these changes
Jan 10, 2020
prestonvanloon
added a commit
that referenced
this pull request
Jan 15, 2020
Merged
cryptomental
pushed a commit
to cryptomental/prysm
that referenced
this pull request
Feb 24, 2020
* Do not panic if initial sync fails * Only consider peers with non-0 finalized epoch * Additional fixes * Fix tests * Merge branch 'master' into mvlog * Merge branch 'master' into mvlog
cryptomental
pushed a commit
to cryptomental/prysm
that referenced
this pull request
Feb 24, 2020
* Partially revert prysmaticlabs#4477
cryptomental
pushed a commit
to cryptomental/prysm
that referenced
this pull request
Feb 28, 2020
* Do not panic if initial sync fails * Only consider peers with non-0 finalized epoch * Additional fixes * Fix tests * Merge branch 'master' into mvlog * Merge branch 'master' into mvlog
cryptomental
pushed a commit
to cryptomental/prysm
that referenced
this pull request
Feb 28, 2020
* Partially revert prysmaticlabs#4477
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This (hasty) patch stops a panic if a node is interrupted during initial sync and as such doesn't complete sync. Sync will end without being marked as complete and will continue next run.