Partially revert #4477 #4550
Merged
Partially revert #4477 #4550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nisdas
approved these changes
Jan 15, 2020
Codecov Report
@@ Coverage Diff @@
## master #4550 +/- ##
==========================================
- Coverage 55.01% 6.89% -48.12%
==========================================
Files 235 192 -43
Lines 16117 13018 -3099
==========================================
- Hits 8866 898 -7968
- Misses 5953 11986 +6033
+ Partials 1298 134 -1164 |
cryptomental
pushed a commit
to cryptomental/prysm
that referenced
this pull request
Feb 24, 2020
* Partially revert prysmaticlabs#4477
cryptomental
pushed a commit
to cryptomental/prysm
that referenced
this pull request
Feb 28, 2020
* Partially revert prysmaticlabs#4477
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Panicking may not the best response to an error, but we were silently throwing the error away and doing nothing about it.
Until we have a better approach, let's partially revert #4477 and panic if sync fails.