Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve Miscellaneous Bugs in Beacon Node #4743

Merged
merged 3 commits into from Feb 4, 2020
Merged

Conversation

rauljordan
Copy link
Contributor

@rauljordan rauljordan commented Feb 4, 2020

This PR is a collection of fixes and small improvements to close out open bug reports.


Description

Write a summary of the changes you are making

@rauljordan rauljordan self-assigned this Feb 4, 2020
@rauljordan rauljordan added the Enhancement New feature or request label Feb 4, 2020
@rauljordan rauljordan added the Ready For Review A pull request ready for code review label Feb 4, 2020
@codecov
Copy link

codecov bot commented Feb 4, 2020

Codecov Report

Merging #4743 into master will increase coverage by 33.85%.
The diff coverage is 25%.

@@             Coverage Diff             @@
##           master    #4743       +/-   ##
===========================================
+ Coverage   12.26%   46.12%   +33.85%     
===========================================
  Files          77      205      +128     
  Lines        6260    15437     +9177     
===========================================
+ Hits          768     7120     +6352     
- Misses       5360     7143     +1783     
- Partials      132     1174     +1042

@rauljordan rauljordan merged commit 061960c into master Feb 4, 2020
@rauljordan rauljordan deleted the resolve-issues branch February 4, 2020 17:21
cryptomental pushed a commit to cryptomental/prysm that referenced this pull request Feb 24, 2020
* add in nil check for head block

* fix logic

* unused import
cryptomental pushed a commit to cryptomental/prysm that referenced this pull request Feb 28, 2020
* add in nil check for head block

* fix logic

* unused import
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request Ready For Review A pull request ready for code review
Projects
None yet
2 participants