Compute state up to slot #5035
Merged
Compute state up to slot #5035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5035 +/- ##
==========================================
+ Coverage 42.99% 44.10% +1.10%
==========================================
Files 267 214 -53
Lines 20111 16628 -3483
==========================================
- Hits 8647 7333 -1314
+ Misses 9987 8000 -1987
+ Partials 1477 1295 -182 |
terencechain
added
Ready For Review
nisdas
reviewed
Mar 8, 2020
| // ComputeStateUpToSlot returns a processed state up to input target slot. | ||
| // If the last processed block is at slot 32, given input target slot at 40, this | ||
| // returns processed state up to slot 40 via empty slots. | ||
| func (s *State) ComputeStateUpToSlot(ctx context.Context, targetSlot uint64) (*state.BeaconState, error) { |
There was a problem hiding this comment.
Ok , what if you have two blocks at slot 30 ? how would you know which state to return ?
There was a problem hiding this comment.
It returns the canonical one (ie ancestor of the canonical chain from the node's point of view)
Will update the comment
0xKiwi
approved these changes
Mar 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added replay function to compute state up to slot, this is really useful if one's interest to know the state at of a given slot. This functionality will also be used for both hot and cold mgmt. Also added tests to go with this