-
Notifications
You must be signed in to change notification settings - Fork 985
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compute state up to slot #5035
Merged
Merged
Compute state up to slot #5035
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
025a755
ComputeStateUpToSlot
terencechain b88b838
Tests
terencechain f790727
Merge branch 'master' into replay-methods
terencechain 33d3cdb
Merge refs/heads/master into replay-methods
prylabs-bulldozer[bot] 5be5b24
Merge refs/heads/master into replay-methods
prylabs-bulldozer[bot] 5f0501b
Merge refs/heads/master into replay-methods
prylabs-bulldozer[bot] 464d4b4
Comment
terencechain 5c0379d
Merge branch 'replay-methods' of https://github.com/prysmaticlabs/pry…
terencechain e15c49e
Merge refs/heads/master into replay-methods
prylabs-bulldozer[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok , what if you have two blocks at slot 30 ? how would you know which state to return ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It returns the canonical one (ie ancestor of the canonical chain from the node's point of view)
Will update the comment