Fix bad log messages for duplicate deposits #5440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nisdas
approved these changes
Apr 15, 2020
Codecov Report
@@ Coverage Diff @@
## master #5440 +/- ##
===========================================
+ Coverage 5.11% 41.81% +36.69%
===========================================
Files 236 236
Lines 20253 20125 -128
===========================================
+ Hits 1036 8415 +7379
+ Misses 19069 10200 -8869
- Partials 148 1510 +1362 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the beacon chain detects a duplicate deposit prior to chainstart it warns of this fact, but the log message as-is prints out the hex value of a text string.
This patch changes the log messages so it prints out the full validator key as a log field, congruent with the message format used for deposits that are included.