Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Separate Network Config #5454

Merged
merged 10 commits into from
Apr 16, 2020
Merged

Add Separate Network Config #5454

merged 10 commits into from
Apr 16, 2020

Conversation

nisdas
Copy link
Member

@nisdas nisdas commented Apr 16, 2020

This adds a separate network config, to store all the network specific values in param

@nisdas nisdas requested a review from a team as a code owner April 16, 2020 12:42
@nisdas nisdas added Networking P2P related items Ready For Review A pull request ready for code review labels Apr 16, 2020
AttestationPropagationSlotRange: 32,
TtfbTimeout: 5 * time.Second,
RespTimeout: 10 * time.Second,
MaximumGossipClockDisparity: 500 * time.Millisecond,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love this naming!

@prylabs-bulldozer prylabs-bulldozer bot merged commit 28733f2 into master Apr 16, 2020
@delete-merged-branch delete-merged-branch bot deleted the configCleanup branch April 16, 2020 22:21
terencechain added a commit that referenced this pull request Apr 18, 2020
terencechain added a commit that referenced this pull request Apr 18, 2020
prylabs-bulldozer bot pushed a commit that referenced this pull request Apr 18, 2020
* Revert "Add WaitForSynced to beacon node for validator startup (#5366)"

This reverts commit 1224e75.
* Merge branch 'master' of github.com:prysmaticlabs/prysm
* Revert "Add Separate Network Config (#5454)"

This reverts commit 28733f2.
* Save blocks to db before generating state
* Revert "Revert "Add Separate Network Config (#5454)""

This reverts commit d43c2b7.
* Revert "Revert "Add WaitForSynced to beacon node for validator startup (#5366)""

This reverts commit 927d8d9.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Networking P2P related items Ready For Review A pull request ready for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants