Save init sync cached blocks before regenerate state #5501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terencechain
added
Ready For Review
rauljordan
approved these changes
Apr 18, 2020
Codecov Report
@@ Coverage Diff @@
## master #5501 +/- ##
===========================================
- Coverage 55.13% 40.85% -14.28%
===========================================
Files 307 237 -70
Lines 25791 20227 -5564
===========================================
- Hits 14219 8264 -5955
- Misses 9573 10445 +872
+ Partials 1999 1518 -481 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #5496
Right after initial syncing, during request block parent phase, there could be an overlapping time where the initial sync blocks are still preserved in cache and not yet getting saved in the DB. This force saves the cached initial sync blocks to DB when a node needs to regenerate the state