Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update remote signer for 0.11 #5602

Merged
merged 6 commits into from
Apr 28, 2020
Merged

Update remote signer for 0.11 #5602

merged 6 commits into from
Apr 28, 2020

Conversation

mcdee
Copy link
Contributor

@mcdee mcdee commented Apr 23, 2020

This re-implements the changes for the remote keymanager to work with the 0.11 spec as per the current testnet.

Original PR was #5260 . Notes from that PR (which was for the 0.10 spec):

A few updates for the remote keymanager after running it in test for a while:

  • increase the maximum message size received from the remote server to allow for larger number of keys
  • do not panic on bad response from remote server
  • check response code when asking for accounts and error on error situations (requires update to eth2-signer-api dependency)
  • when receiving list of accounts to validate with from the remote server check them against user-supplied path specifier to ensure we aren't validating accounts we shouldn't

In addition this provides the proposer index as part of beacon proposal signing request, as per the change in 0.11.

Part of #5423

@mcdee mcdee requested a review from a team as a code owner April 23, 2020 21:39
@codecov
Copy link

codecov bot commented Apr 23, 2020

Codecov Report

Merging #5602 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #5602   +/-   ##
=======================================
  Coverage   53.48%   53.48%           
=======================================
  Files         309      309           
  Lines       25575    25575           
=======================================
  Hits        13680    13680           
  Misses       9866     9866           
  Partials     2029     2029           

@rauljordan rauljordan merged commit 9d173dc into prysmaticlabs:master Apr 28, 2020
@mcdee mcdee deleted the remote-signer-update branch April 28, 2020 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants