Revert "Check Whether Block Is Already Processed" #5856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 7630f18.
nisdas
approved these changes
May 14, 2020
farazdagi
approved these changes
May 14, 2020
Codecov Report
@@ Coverage Diff @@
## master #5856 +/- ##
==========================================
- Coverage 60.61% 59.93% -0.69%
==========================================
Files 313 312 -1
Lines 27389 26213 -1176
==========================================
- Hits 16603 15710 -893
+ Misses 8612 8366 -246
+ Partials 2174 2137 -37 |
michaelhly
pushed a commit
to michaelhly/prysm
that referenced
this pull request
May 14, 2020
* Revert "Check Whether Block Is Already Processed (prysmaticlabs#5850)" This reverts commit 7630f18.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #5850
Per discussion with @nisdas and @farazdagi , we have concluded that it would be more complicated to satisfy this for
new-state-mgmt, and it would make more sense to check this in initial sync and remove duplicated blocks from the syncing queue