Improve Deposit Data Account Creation Prompt #5985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rauljordan
commented
May 25, 2020
| publicKey := validatorKey.PublicKey.Marshal()[:] | ||
| log.Infof("Deposit data displayed for public key: %#x", publicKey) |
There was a problem hiding this comment.
This text was confusing to the user as well
rauljordan
added
OK to merge
Ready For Review
farazdagi
approved these changes
May 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What does this PR do? Why is it needed?
A user reported the account creation deposit data is not quite clear, so they ended up pasting their public key into the prylabs.net/participate portal instead. This is because, intuitively, the user ignored the
======RAW TRANSACTION DATA======text blob in the terminal. Instead, we should rename that toDEPOSIT DATAand mention clearly to paste in the deposit data shown above into the prylabs.net/participate page.