Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Deposit Data Account Creation Prompt #5985

Merged
merged 5 commits into from
May 26, 2020
Merged

Improve Deposit Data Account Creation Prompt #5985

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0520137
improve validator accounts create text
rauljordan May 25, 2020
25c1c91
Merge refs/heads/master into improve-deposit-data-promt
prylabs-bulldozer[bot] May 25, 2020
754d3a8
Merge refs/heads/master into improve-deposit-data-promt
prylabs-bulldozer[bot] May 26, 2020
81c96ce
Merge refs/heads/master into improve-deposit-data-promt
prylabs-bulldozer[bot] May 26, 2020
d016dfe
Merge refs/heads/master into improve-deposit-data-promt
prylabs-bulldozer[bot] May 26, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 4 additions & 4 deletions validator/accounts/account.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,17 +105,17 @@ func NewValidatorAccount(directory string, password string) error {
if err != nil {
return errors.Wrap(err, "unable to create deposit transaction")
}
log.Info(`Account creation complete! Copy and paste the raw transaction data shown below when issuing a transaction into the ETH1.0 deposit contract to activate your validator client`)
log.Info(`Account creation complete! Copy and paste the raw deposit data shown below when issuing a transaction into the ETH1.0 deposit contract to activate your validator client`)
fmt.Printf(`
========================Raw Transaction Data=======================
========================Deposit Data=======================

%#x

===================================================================
`, tx.Data())
fmt.Println("***Enter the above Raw Transaction Data into step 3 on https://prylabs.net/participate***")
fmt.Println("***Enter the above deposit data into step 3 on https://prylabs.net/participate***")
publicKey := validatorKey.PublicKey.Marshal()[:]
log.Infof("Deposit data displayed for public key: %#x", publicKey)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This text was confusing to the user as well

log.Infof("Public key: %#x", publicKey)
return nil
}

Expand Down
3 changes: 1 addition & 2 deletions validator/accounts/account_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,11 +15,10 @@ import (

"github.com/prysmaticlabs/go-bitfield"
slashpb "github.com/prysmaticlabs/prysm/proto/slashing"
"github.com/prysmaticlabs/prysm/validator/db"

"github.com/prysmaticlabs/prysm/shared/keystore"
"github.com/prysmaticlabs/prysm/shared/params"
"github.com/prysmaticlabs/prysm/shared/testutil"
"github.com/prysmaticlabs/prysm/validator/db"
"github.com/prysmaticlabs/prysm/validator/flags"
"gopkg.in/urfave/cli.v2"
)
Expand Down