Fix Fork Data in Local Node #5997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nisdas
added
Ready For Review
farazdagi
reviewed
May 26, 2020
Co-authored-by: Victor Farazdagi <simple.square@gmail.com>
rauljordan
previously approved these changes
May 26, 2020
Codecov Report
@@ Coverage Diff @@
## master #5997 +/- ##
==========================================
+ Coverage 59.54% 59.61% +0.06%
==========================================
Files 320 320
Lines 26991 27011 +20
==========================================
+ Hits 16073 16102 +29
+ Misses 8731 8721 -10
- Partials 2187 2188 +1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug Fix
What does this PR do? Why is it needed?
We only set the next fork version if there is a fork scheduled. We instead
set it all the time,which caused peering issues in witti.
Which issues(s) does this PR fix?
N.A
Other notes for review
N.A