Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Fork Data in Local Node #5997

Merged
merged 13 commits into from
May 27, 2020
1 change: 1 addition & 0 deletions beacon-chain/p2p/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ go_library(
"//beacon-chain/cache:go_default_library",
"//beacon-chain/core/feed:go_default_library",
"//beacon-chain/core/feed/state:go_default_library",
"//beacon-chain/core/helpers:go_default_library",
"//beacon-chain/p2p/connmgr:go_default_library",
"//beacon-chain/p2p/encoder:go_default_library",
"//beacon-chain/p2p/peers:go_default_library",
Expand Down
20 changes: 19 additions & 1 deletion beacon-chain/p2p/fork.go
Original file line number Diff line number Diff line change
Expand Up @@ -4,15 +4,18 @@ import (
"bytes"
"encoding/base64"
"fmt"
"math"
"time"

"github.com/ethereum/go-ethereum/p2p/enode"
"github.com/ethereum/go-ethereum/p2p/enr"
"github.com/pkg/errors"
"github.com/prysmaticlabs/go-ssz"
"github.com/prysmaticlabs/prysm/beacon-chain/core/helpers"
pb "github.com/prysmaticlabs/prysm/proto/beacon/p2p/v1"
"github.com/prysmaticlabs/prysm/shared/p2putils"
"github.com/prysmaticlabs/prysm/shared/params"
"github.com/prysmaticlabs/prysm/shared/roughtime"
"github.com/sirupsen/logrus"
)

Expand Down Expand Up @@ -86,10 +89,25 @@ func addForkEntry(
if err != nil {
return nil, err
}
currentSlot := helpers.SlotsSince(genesisTime)
currentEpoch := helpers.SlotToEpoch(currentSlot)
if roughtime.Now().Before(genesisTime) {
currentSlot, currentEpoch = 0, 0
}
fork, err := p2putils.Fork(currentEpoch)
if err != nil {
return nil, err
}

nextForkEpoch := params.BeaconConfig().NextForkEpoch
nextForkVersion := params.BeaconConfig().NextForkVersion
nisdas marked this conversation as resolved.
Show resolved Hide resolved
// Set to the current fork version if our next fork is not planned.
if nextForkEpoch == math.MaxUint64 {
nextForkVersion = fork.CurrentVersion
}
enrForkID := &pb.ENRForkID{
CurrentForkDigest: digest[:],
NextForkVersion: params.BeaconConfig().NextForkVersion,
NextForkVersion: nextForkVersion,
NextForkEpoch: nextForkEpoch,
}
enc, err := ssz.Marshal(enrForkID)
Expand Down
17 changes: 4 additions & 13 deletions shared/p2putils/fork.go
Original file line number Diff line number Diff line change
Expand Up @@ -26,19 +26,12 @@ func CreateForkDigest(
currentSlot := helpers.SlotsSince(genesisTime)
currentEpoch := helpers.SlotToEpoch(currentSlot)

// We retrieve a list of scheduled forks by epoch.
// We loop through the keys in this map to determine the current
// fork version based on the current, time-based epoch number
// since the genesis time.
currentForkVersion := params.BeaconConfig().GenesisForkVersion
scheduledForks := params.BeaconConfig().ForkVersionSchedule
for epoch, forkVersion := range scheduledForks {
if epoch <= currentEpoch {
currentForkVersion = forkVersion
}
forkData, err := Fork(currentEpoch)
if err != nil {
return [4]byte{}, err
}

digest, err := helpers.ComputeForkDigest(currentForkVersion, genesisValidatorsRoot)
digest, err := helpers.ComputeForkDigest(forkData.CurrentVersion, genesisValidatorsRoot)
if err != nil {
return [4]byte{}, err
}
Expand All @@ -62,10 +55,8 @@ func Fork(
previousForkVersion = retrievedForkVersion
retrievedForkVersion = forkVersion
forkEpoch = epoch

}
}

return &pb.Fork{
PreviousVersion: previousForkVersion,
CurrentVersion: retrievedForkVersion,
Expand Down