Accounts V2: Fix issues reported by rkapka #6725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #6725 +/- ##
==========================================
+ Coverage 60.07% 62.19% +2.12%
==========================================
Files 323 384 +61
Lines 27422 29465 +2043
==========================================
+ Hits 16473 18327 +1854
+ Misses 8733 8544 -189
- Partials 2216 2594 +378 |
|
The referenced issue has been merged into #6715. |
35 tasks
0xKiwi
commented
Jul 27, 2020
| fmt.Printf("%s %s\n", au.BrightCyan("[created at]").Bold(), humanize.Time(unixTimestamp)) | ||
|
|
||
| fmt.Printf("%s | %s\n", au.BrightGreen(accountNames[i]).Bold(), humanize.Time(unixTimestamp)) | ||
| fmt.Printf("%s %#x\n", au.BrightMagenta("[validating public key]").Bold(), pubKeys[i]) |
There was a problem hiding this comment.
We should abstract this logging into a shared function if possible
0xKiwi
commented
Jul 27, 2020
| return errors.Wrap(err, "could not check if wallet directory exists") | ||
| } | ||
| if errors.Is(err, ErrWalletExists) { | ||
| return ErrWalletExists |
There was a problem hiding this comment.
Just returning the wallet exists error here so it doesn't pass through could not check if wallet directory exists
rauljordan
reviewed
Jul 27, 2020
Co-authored-by: Raul Jordan <raul@prysmaticlabs.com>
rauljordan
approved these changes
Jul 28, 2020
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug fix and cleanup
What does this PR do? Why is it needed?
Part of #6723, this solves some of the issues reported by rkapka. Issues includes:
--skip-mnemonic-confirm being on
accounts-v2 create help--password-file flag not being allowed in runtime
Allowing "y" or "Y" for prompt confirmation entry.
Cleaning up errors for invalid words entered for mnemonics, or just entirely invalid mnemonics
Fixing formatting of accounts list from derived vs. non-hd
Solves some formatting and test issues for logs
Adds an error if you try to import non-HD accounts into a HD wallet
Also fixes a bug with password file entry