-
Notifications
You must be signed in to change notification settings - Fork 962
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Accounts V2: Fix issues reported by rkapka #6725
Merged
Merged
Changes from all commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
8371721
Fix accounts v2 runtime
0xKiwi 00ddf7a
Accounts V2: Fix issues found by rkapka
0xKiwi 89d1e45
Add to help
0xKiwi fc5b18a
Merge refs/heads/master into fix-v2-runtime
prylabs-bulldozer[bot] f48a3a8
Merge refs/heads/master into fix-v2-runtime
prylabs-bulldozer[bot] 9d0badc
Merge refs/heads/master into fix-v2-runtime
prylabs-bulldozer[bot] 28bf3a8
Merge refs/heads/master into fix-v2-runtime
prylabs-bulldozer[bot] 0ce1fa8
Fixes
0xKiwi 2c34570
add back error
0xKiwi 3d90d2a
Make new wallet error cleaner
0xKiwi 1d9841d
Fix text
0xKiwi a9c05f6
Fix log
0xKiwi 55c6a9f
Add case for normal error
0xKiwi 3f80b65
Update validator/flags/flags.go
0xKiwi 7de0d0d
Merge branch 'master' of github.com:prysmaticlabs/prysm into fix-v2-r…
0xKiwi 3d414e0
Merge refs/heads/master into fix-v2-runtime
prylabs-bulldozer[bot] 1c01a86
Fix comment
0xKiwi 6aac7db
Merge refs/heads/master into fix-v2-runtime
prylabs-bulldozer[bot] 7765165
fix comment
0xKiwi 501ea39
Fix test
0xKiwi 5c6b007
Merge branch 'master' into fix-v2-runtime
rauljordan e2de281
Merge refs/heads/master into fix-v2-runtime
prylabs-bulldozer[bot] 19db83c
Merge refs/heads/master into fix-v2-runtime
prylabs-bulldozer[bot] 1b61794
Merge refs/heads/master into fix-v2-runtime
prylabs-bulldozer[bot] d08ff87
Merge refs/heads/master into fix-v2-runtime
prylabs-bulldozer[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -21,8 +21,11 @@ func CreateWallet(cliCtx *cli.Context) error { | |
return err | ||
} | ||
w, err := NewWallet(cliCtx, keymanagerKind) | ||
if err != nil { | ||
return errors.Wrap(err, "could not create a new wallet") | ||
if err != nil && !errors.Is(err, ErrWalletExists) { | ||
return errors.Wrap(err, "could not check if wallet directory exists") | ||
} | ||
if errors.Is(err, ErrWalletExists) { | ||
return ErrWalletExists | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Just returning the wallet exists error here so it doesn't pass through |
||
} | ||
switch w.KeymanagerKind() { | ||
case v2keymanager.Direct: | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should abstract this logging into a shared function if possible