Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Accounts Revamp Fixes: "Overall" Wallet Improvements #6736
Accounts Revamp Fixes: "Overall" Wallet Improvements #6736
Changes from 20 commits
bf37112
25a2463
dd4b683
d485e09
631e9b0
15ada8f
092b43a
b73fe3f
55d31b7
c53848e
2010530
cc37d1e
c2a0ec8
1886052
232bcf5
758d72a
9a71304
308e91e
17fa95e
de054c8
cfc7a90
0c05bdb
71093ed
25563eb
f4c6765
8665bbf
7d38761
4b237aa
78549d1
205cbe8
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like this is the export code. Instead of directing the user to create a wallet, maybe we could just inform them there is nothing to export?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you add a test case with where no wallet exists?