Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check ListValidatorBalances response length #7583

Merged
merged 4 commits into from
Oct 20, 2020
Merged

Check ListValidatorBalances response length #7583

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3fed0c5
Check length
terencechain Oct 20, 2020
ac635fb
Add regression test
terencechain Oct 20, 2020
d953071
Merge branch 'master' of github.com:prysmaticlabs/prysm into list-bal…
terencechain Oct 20, 2020
f3519d9
Merge refs/heads/master into list-balances
prylabs-bulldozer[bot] Oct 20, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions beacon-chain/rpc/beacon/validators.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,6 +162,10 @@ func (bs *Server) ListValidatorBalances(
}, nil
}

if end > len(res) || end < start {
return nil, status.Error(codes.OutOfRange, "Request exceeds response length")
}

return &ethpb.ValidatorBalances{
Epoch: requestedEpoch,
Balances: res[start:end],
Expand Down
27 changes: 27 additions & 0 deletions beacon-chain/rpc/beacon/validators_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -372,6 +372,33 @@ func TestServer_ListValidatorBalances_Pagination_CustomPageSizes(t *testing.T) {
}
}

func TestServer_ListValidatorBalances_ResponseOutOfBound(t *testing.T) {
db, sc := dbTest.SetupDB(t)
ctx := context.Background()

count := 10
setupValidators(t, db, count)
headState, err := db.HeadState(context.Background())
require.NoError(t, err)
b := testutil.NewBeaconBlock()
gRoot, err := b.Block.HashTreeRoot()
require.NoError(t, err)
require.NoError(t, db.SaveGenesisBlockRoot(ctx, gRoot))
require.NoError(t, db.SaveState(ctx, headState, gRoot))

bs := &Server{
GenesisTimeFetcher: &mock.ChainService{},
StateGen: stategen.New(db, sc),
HeadFetcher: &mock.ChainService{
State: headState,
},
}

req := &ethpb.ListValidatorBalancesRequest{PageSize: 250, QueryFilter: &ethpb.ListValidatorBalancesRequest_Epoch{Epoch: 0}, PublicKeys: [][]byte{{'a'}}}
_, err = bs.ListValidatorBalances(context.Background(), req)
require.ErrorContains(t, "Request exceeds response length", err)
}

func TestServer_ListValidatorBalances_OutOfRange(t *testing.T) {
db, sc := dbTest.SetupDB(t)

Expand Down