Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check ListValidatorBalances response length #7583

Merged
merged 4 commits into from
Oct 20, 2020
Merged

Check ListValidatorBalances response length #7583

merged 4 commits into from
Oct 20, 2020

Conversation

terencechain
Copy link
Member

This fixes #7581, it checks the response length before return

@terencechain terencechain added the Ready For Review A pull request ready for code review label Oct 20, 2020
@terencechain terencechain requested a review from a team as a code owner October 20, 2020 19:05
@terencechain terencechain self-assigned this Oct 20, 2020
@terencechain terencechain removed the Ready For Review A pull request ready for code review label Oct 20, 2020
@terencechain terencechain marked this pull request as draft October 20, 2020 19:41
@terencechain terencechain added Ready For Review A pull request ready for code review OK to merge labels Oct 20, 2020
@terencechain terencechain marked this pull request as ready for review October 20, 2020 20:05
@prylabs-bulldozer prylabs-bulldozer bot merged commit 544dac2 into master Oct 20, 2020
@delete-merged-branch delete-merged-branch bot deleted the list-balances branch October 20, 2020 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rauljordan rauljordan rauljordan approved these changes

@shayzluf shayzluf Awaiting requested review from shayzluf

@0xKiwi 0xKiwi Awaiting requested review from 0xKiwi

@rkapka rkapka Awaiting requested review from rkapka

Assignees

@terencechain terencechain

Labels
Ready For Review A pull request ready for code review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

error msg="gRPC panicked!" error="runtime error: slice bounds out of range [:250] with capacity 1"
2 participants
@terencechain @rauljordan