Correct how AllValidatorsAreExited creates status request #7758
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What does this PR do? Why is it needed?
This bug fixes #7707 -- If you look at this in validator/client/validator.go
What I saw during debugging is that after the range-for loop, publicKeys ends up with a set of identical keys that match the last key appended. This is likely because the iterating variable (key)'s memory address is appended and since this address will last hold the last key iterated over in validatorKeys, publicKey ends up with multiple copies of the same key. If the validator associated with the last key is exited, then this function will true that all validators are exited and this leads to the described bug. To fix this I just create a copy and append that instead. There is a regression test created as well which creates a couple of sample keys and sees if the request is as expected. This test fails on current master and passes with this PR.
Which issues(s) does this PR fix?
Fixes #7707
Other notes for review