Save GenesisValidatorsRoot from WaitForChainStart #7855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shayzluf
reviewed
Nov 18, 2020
| bkt := tx.Bucket(genesisInfoBucket) | ||
| enc := bkt.Get(genesisValidatorsRootKey) | ||
| if len(enc) != 0 { | ||
| return fmt.Errorf("cannot overwite existing genesis validators root: %#x", enc) |
There was a problem hiding this comment.
i think it should be fatal log as well
There was a problem hiding this comment.
The fatal log should be by the caller of this function
rauljordan
approved these changes
Nov 20, 2020
rauljordan
added
OK to merge
Ready For Review
21 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Feature change
What does this PR do? Why is it needed?
This PR adds
GenesisValidatorsRootandSaveGenesisValidatorsRootto the DB. It also changesWaitForChainStartto save the received GenesisValidatorsRoot to DB.