Verify GenesisValidatorRoot Matches the One in DB on Slashing Protection Import #7864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…validateMetadata_genesis # Conflicts: # validator/client/validator.go # validator/db/kv/BUILD.bazel
rauljordan
changed the title
rauljordan
reviewed
Nov 20, 2020
| if err != nil { | ||
| return fmt.Errorf("%#x is not a valid root: %v", interchangeJSON.Metadata.GenesisValidatorsRoot, err) | ||
| } | ||
| if err = validatorDB.SaveGenesisValidatorsRoot(ctx, gvr[:]); err != nil { |
There was a problem hiding this comment.
This is incorrect, we should instead fetch the genesis validators root and compare it. We should not save what we get from the JSON file like this
There was a problem hiding this comment.
@rauljordan save detects difference and returns error. will change to fetch
There was a problem hiding this comment.
Yes but the name is misleading though, we should just do db.GenesisValidatorsRoot and do a simple comparison
21 tasks
…esis_on_wait_chainstart # Conflicts: # validator/db/kv/genesis.go
rauljordan
approved these changes
Nov 20, 2020
rauljordan
added
OK to merge
Ready For Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds off #7855
Feature
What does this PR do? Why is it needed?
Genesis validator root is being used for signing attestation and block proposals
making sure beacon node use the same genesis validator root as the one that is stored in the slashing protection db makes sure we are on the right chain.
Which issues(s) does this PR fix?
Fixes #
Other notes for review