Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update grpc-gateway dependency #8929

Merged
merged 1 commit into from
May 24, 2021
Merged

Update grpc-gateway dependency #8929

merged 1 commit into from
May 24, 2021

Conversation

rkapka
Copy link
Contributor

@rkapka rkapka commented May 24, 2021

What type of PR is this?

Bug fix

What does this PR do? Why is it needed?

Because of updating grpc-gateway from v1 to v2 in #8697, existing v1alpha1 APIs stopped working correctly when the URL included specific chars in a base64-encoded parameter. prysmaticlabs/grpc-gateway#7 fixed the issue so now we have to update the dependency.

Which issues(s) does this PR fix?

N/A

Other notes for review

N/A

@rkapka rkapka requested a review from a team as a code owner May 24, 2021 10:53
@rkapka rkapka requested review from kasey, jmozah and 0xKiwi May 24, 2021 10:53
@rkapka rkapka added Ready For Review A pull request ready for code review API Api related tasks labels May 24, 2021
@codecov
Copy link

codecov bot commented May 24, 2021

Codecov Report

Merging #8929 (3e0ad32) into develop (503ec12) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #8929      +/-   ##
===========================================
- Coverage    60.87%   60.84%   -0.03%     
===========================================
  Files          528      528              
  Lines        37346    37346              
===========================================
- Hits         22736    22725      -11     
- Misses       11347    11357      +10     
- Partials      3263     3264       +1     

@rauljordan rauljordan merged commit 180b844 into develop May 24, 2021
@delete-merged-branch delete-merged-branch bot deleted the update-grpc-gateway branch May 24, 2021 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Api related tasks Ready For Review A pull request ready for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants