Various bug fixes in Eth API #9649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkapka
added
Ready For Review
rkapka
requested review from
prestonvanloon,
terencechain and
nisdas
and removed request for
a team
Codecov Report
@@ Coverage Diff @@
## develop #9649 +/- ##
===========================================
- Coverage 61.93% 61.92% -0.02%
===========================================
Files 564 564
Lines 44646 44645 -1
===========================================
- Hits 27653 27647 -6
+ Misses 12513 12512 -1
- Partials 4480 4486 +6 |
rkapka
changed the title
| Data: &beaconBlockContainerJson{ | ||
| Message: respContainer.Data.Phase0Block, | ||
| }, | ||
| Data: respContainer.Data.Phase0Block, |
There was a problem hiding this comment.
Does this need a regression test? Im surprised there's 0 test change to reflect on
There was a problem hiding this comment.
I improved block serialization tests.
kasey
reviewed
Sep 22, 2021
| Version string `json:"version"` | ||
| Data *beaconBlockAltairContainerJson `json:"data"` | ||
| Version string `json:"version"` | ||
| Data *beaconBlockAltairJson `json:"data"` |
There was a problem hiding this comment.
presumably this is addressing Fixes wrong block structure for /eth/v2/validator/blocks?
There was a problem hiding this comment.
Yes, this is correct. We don't need an additional wrapper, we should use beaconBlockAltairJson directly.
terencechain
approved these changes
Sep 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug fix
What does this PR do? Why is it needed?
/eth/v2/validator/blocksNotFoundwhen block returned from core libraries is nil/internalgrpc-gateway paths work with events and SSZ endpointsWhich issues(s) does this PR fix?
Fixes #9647
Fixes #9636
Fixes #9652