Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deregister Remote Slashing Protection Until Further Notice #9774

Merged
merged 8 commits into from Oct 14, 2021

Conversation

rauljordan
Copy link
Contributor

Slashing protection is one of the riskiest features to include in an Ethereum beacon chain implementation. Prysm today supports three methods

  1. Local slashing protection database. This is enabled for every validator client, cannot be disabled, and is, in general, a quite safe way of protecting against double signing of data
  2. Doppelganger detection. This is an optional feature that looks at some beacon chain information to determine if a validator key is performing its duties on chain. This can halt the process right away and is helpful for preventing getting slashed in case a user is running the same validator key but on a different machine. It is not perfect and redundant key setups should be avoided at all costs.
  3. Remote slashing protection using a slasher. Slasher is a process that acts as the "police" of the network. It is a highly resource intensive process, and is not bug-free. The team is still working on improving slasher. However, trusting software that is still being drastically improved with something as risky as "slashing protection" is dangerous.

It has been brought to our attention that slasher currently returns incorrect data for its HighestAttestations endpoint, which is used by some stakers for slashing protection. We believe this is a serious risk and are now disabling the ability for validator clients to use remote slashing protection until we feel 100% confident in its safety for further notice.

@rauljordan rauljordan requested a review from a team as a code owner October 14, 2021 18:42
@rauljordan rauljordan self-assigned this Oct 14, 2021
@rauljordan rauljordan added OK to merge Ready For Review A pull request ready for code review labels Oct 14, 2021
config/features/config.go Outdated Show resolved Hide resolved
@prylabs-bulldozer prylabs-bulldozer bot merged commit 59547ae into develop Oct 14, 2021
@delete-merged-branch delete-merged-branch bot deleted the rem-slasherpb-register branch October 14, 2021 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready For Review A pull request ready for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants