Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deregister Remote Slashing Protection Until Further Notice #9774

Merged
merged 8 commits into from Oct 14, 2021
Merged

Deregister Remote Slashing Protection Until Further Notice #9774

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
99eb413
avoid registering
rauljordan Oct 14, 2021
d8772b2
disable endpoints
rauljordan Oct 14, 2021
4d0dea3
remote slasher protection register
rauljordan Oct 14, 2021
fd227c7
gaz
rauljordan Oct 14, 2021
1d02f20
Merge refs/heads/develop into rem-slasherpb-register
prylabs-bulldozer[bot] Oct 14, 2021
1027aad
fatal on external protection flag call
rauljordan Oct 14, 2021
0074df3
Merge branch 'rem-slasherpb-register' of github.com:prysmaticlabs/pry…
rauljordan Oct 14, 2021
ed3a4de
radek comment
rauljordan Oct 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 0 additions & 1 deletion beacon-chain/rpc/BUILD.bazel
View file
Open in desktop
Expand Up @@ -30,7 +30,6 @@ go_library(
"//beacon-chain/rpc/prysm/v1alpha1/beacon:go_default_library",
"//beacon-chain/rpc/prysm/v1alpha1/debug:go_default_library",
"//beacon-chain/rpc/prysm/v1alpha1/node:go_default_library",
"//beacon-chain/rpc/prysm/v1alpha1/slasher:go_default_library",
"//beacon-chain/rpc/prysm/v1alpha1/validator:go_default_library",
"//beacon-chain/rpc/statefetcher:go_default_library",
"//beacon-chain/slasher:go_default_library",
Expand Down
6 changes: 0 additions & 6 deletions beacon-chain/rpc/service.go
View file
Open in desktop
Expand Up @@ -34,7 +34,6 @@ import (
beaconv1alpha1 "github.com/prysmaticlabs/prysm/beacon-chain/rpc/prysm/v1alpha1/beacon"
debugv1alpha1 "github.com/prysmaticlabs/prysm/beacon-chain/rpc/prysm/v1alpha1/debug"
nodev1alpha1 "github.com/prysmaticlabs/prysm/beacon-chain/rpc/prysm/v1alpha1/node"
slasherv1alpha1 "github.com/prysmaticlabs/prysm/beacon-chain/rpc/prysm/v1alpha1/slasher"
validatorv1alpha1 "github.com/prysmaticlabs/prysm/beacon-chain/rpc/prysm/v1alpha1/validator"
"github.com/prysmaticlabs/prysm/beacon-chain/rpc/statefetcher"
slasherservice "github.com/prysmaticlabs/prysm/beacon-chain/slasher"
Expand Down Expand Up @@ -237,10 +236,6 @@ func (s *Service) Start() {
HeadFetcher: s.cfg.HeadFetcher,
}

slasherServer := &slasherv1alpha1.Server{
SlashingChecker: s.cfg.SlashingChecker,
}

beaconChainServer := &beaconv1alpha1.Server{
Ctx: s.ctx,
BeaconDB: s.cfg.BeaconDB,
Expand Down Expand Up @@ -287,7 +282,6 @@ func (s *Service) Start() {
ethpbv1alpha1.RegisterNodeServer(s.grpcServer, nodeServer)
ethpbservice.RegisterBeaconNodeServer(s.grpcServer, nodeServerV1)
ethpbv1alpha1.RegisterHealthServer(s.grpcServer, nodeServer)
ethpbv1alpha1.RegisterSlasherServer(s.grpcServer, slasherServer)
ethpbv1alpha1.RegisterBeaconChainServer(s.grpcServer, beaconChainServer)
ethpbservice.RegisterBeaconChainServer(s.grpcServer, beaconChainServerV1)
ethpbservice.RegisterEventsServer(s.grpcServer, &events.Server{
Expand Down
6 changes: 4 additions & 2 deletions config/features/config.go
View file
Open in desktop
Expand Up @@ -233,8 +233,10 @@ func ConfigureValidator(ctx *cli.Context) {
cfg := &Flags{}
configureTestnet(ctx, cfg)
if ctx.Bool(enableExternalSlasherProtectionFlag.Name) {
log.WithField(enableExternalSlasherProtectionFlag.Name, enableExternalSlasherProtectionFlag.Usage).Warn(enabledFeatureFlag)
cfg.RemoteSlasherProtection = true
log.Fatal(
"Remote slashing protection has currently been disabled in Prysm due to safety concerns. " +
"We appreciate your understanding in our desire to keep Prysm validators safe.",
)
}
if ctx.Bool(writeWalletPasswordOnWebOnboarding.Name) {
logEnabled(writeWalletPasswordOnWebOnboarding)
Expand Down