Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bdmfs_vfat crashes when inserting exFat drive #284

Open
rickgaiser opened this issue Jun 17, 2022 · 0 comments
Open

bdmfs_vfat crashes when inserting exFat drive #284

rickgaiser opened this issue Jun 17, 2022 · 0 comments

Comments

@rickgaiser
Copy link
Member

After #258 the filtering on partition types have been removed. This fixes the FAT32 "removable media" type drives that have no partition table.

But without the filtering, the driver tries to mount every filesystem, resulting in a crash when the filesystem is not supported (like exFat, but probably also with others).

Possible solutions:

  1. Fix the filtering so the driver only tries moounting supported file systems, but then: how to handle the "removable media" type drives that have no partition ID?
  2. Fix bdmfs_vfat to determine for itself if the filesystem is supported or not
  3. Stop using bdmfs_vfat, and switch to bdmfs_fatfs.

I'm choosing the last option, but I know there's many applications still using this driver.

For reference, filtering can be enabled here:

// Filter for supported partition IDs:
// - 0x0b = FAT32 with CHS addressing
// - 0x0c = FAT32 with LBA addressing
// AKuHAK: dont filter partition, fat_getPartitionBootSector() will care about that, this is filtering too much
// if (bd->parId != 0x0b && bd->parId != 0x0c)
// return -1;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant