This repository has been archived by the owner on Feb 9, 2018. It is now read-only.
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Retain compatibility with existing plugins.
- Loading branch information
fbe0226
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This method is still a bad idea for the reasons I outlined.
I repeat: what is the actual limitation this is addressing? Which renderer? What is the maximum number of characters it can display for a filename? If the constraint can be met by the other abbreviations (or by hiding the engine name) then this hack is not needed. Even if it's not met, the hack can be isolated (by implementing a private abbreviation method in DLNAResource) without contaminating the engine API.
It is not part of an engine's contract to expose an identifier that accommodates the undocumented limitation of one renderer. Adding a completely unrelated method to the engine base class is exactly the kind of tightly-coupled legacy hack we're trying to deprecate and remove.
fbe0226
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in 510529e.
fbe0226
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I now understand that you're on about the very existence of the method.
Your fix is fine with me, thanks.