Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed folder structure #233

Closed
tapmantwo opened this issue Nov 22, 2017 · 4 comments
Closed

Changed folder structure #233

tapmantwo opened this issue Nov 22, 2017 · 4 comments
Labels

Comments

@tapmantwo
Copy link

Hi - not a major gripe, but the latest release has moved the actual scripts and modules from \tools to \tools\psake.

Given instructions say to 'change directory to where the psake.pm1 file is', that's a bit of shame. We've had to update our build to the new location.

Was there a good reason for this change?

@devblackops
Copy link
Member

Hi @tapmantwo. This was a side effect of moving the actual PS module under the src folder instead of having everything at the root of the project. The build process followed suit. See #226. Perhaps psake.ps1 and psake.cmd should be moved back to \tools instead of \tools\psake during the nuget build process.

Are one of those two files what you're actually calling instead of the module directly?

Sorry for the headache

-Brandon

@tapmantwo
Copy link
Author

tapmantwo commented Nov 24, 2017

Hi Brandon - I don't think you necessarily have to make any changes if you feel the original change was necessary. I just wanted to flag it up as a 'breaking' change so to speak.

We do run the ps1 file directly - partly because of ignorance, but the readme does also say CD into the directory where you extracted the project (where the psake.psm1 file is). Is it best practise to run the init.ps1 from the .\tools folder instead, and use the module instead?

@devblackops
Copy link
Member

I think the readme should be updated. Since psake is in the PowerShell Gallery now, the preferred way to install it is via Install-Module and not to manually download the artifact zip. You can then just use invoke-psake directly and not have to use the psake.ps1/psake.cmd shims.

@jozefizso
Copy link

Our build scripts have issues with this change too.

Changing folder structure is a breaking change, yet it happened in a minor release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants