Return a generic array in Query

[2e3s]

This may not be a list, it may be an indexed array. Example:
https://github.com/doctrine/orm/blob/bfed8cb6ed448f4ab1ea3fff06e4d6c44439e4ef/lib/Doctrine/ORM/Internal/Hydration/ObjectHydrator.php#L491

This is a potential error like

ERROR: RedundantFunctionCallGivenDocblockType - src/*** - The call to array_values is unnecessary given the list docblock type list<mixed> (see https://psalm.dev/281)
        return array_values($result);

[orklah]

Can the type of the index be determined somehow?

[2e3s]

The type is taken from DB, it's a type of the field. It's possible to parametrize Query with this key as a template, not sure if it's worth it.

[orklah]

Thanks!

[VincentLanglet]

Is the commit a3a972c really useful ?

Changing the generic signature is kinda a BC break for all static analysis users. And it create conflict with others tools like phpstan (as showed here phpstan/phpstan-doctrine#377). This shouldn't be done so easily.

I dunno how it works but array can be written with one template array<mixed> and two templates array<array-key, mixed>. Isn't possible to do the same in such situation in the futur ?