Return a generic array in Query #385
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
annuh
commented
Oct 27, 2022
| */ | ||
| final class Query extends AbstractQuery | ||
| { | ||
| public const HYDRATE_OBJECT = 1; |
There was a problem hiding this comment.
This was needed to fix:
------ ------------------------------------------------
Line stubs/ORM/Query.stub
------ ------------------------------------------------
23 PHPDoc tag @return contains unresolvable type.
------ ------------------------------------------------
annuh
commented
Oct 27, 2022
| { | ||
| assertType( | ||
| 'mixed', | ||
| 'array<(int|string)>', |
There was a problem hiding this comment.
TBH, I'm not really sure about these changes but all the tests pass now 🙄
janedbal
reviewed
Nov 4, 2022
| php vendor/bin/phpstan analyse -l 8 -c phpstan.neon src tests | ||
|
|
||
| .PHONY: phpstan-generate-baseline | ||
| .PHONY: phpstan-generate-baselmake ine |
janedbal
reviewed
Nov 4, 2022
| namespace Doctrine\ORM; | ||
|
|
||
| /** | ||
| * @template TKey as array-key |
There was a problem hiding this comment.
This might be conflicting with the solution propsed in #384
|
Superseded by 4490e56 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #377.
Same as psalm/psalm-plugin-doctrine#115, but for PHPStan 🙂