Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Immutable refactoring #123

Merged
merged 4 commits into from Nov 1, 2022
Merged

Immutable refactoring #123

merged 4 commits into from Nov 1, 2022

Conversation

danog
Copy link
Contributor

@danog danog commented Oct 22, 2022

No description provided.

@orklah
Copy link
Contributor

orklah commented Oct 23, 2022

Thanks, but we'll need to make the split for Psalm 5 with this. We can't make a release compatible with both

@danog
Copy link
Contributor Author

danog commented Oct 31, 2022

This should do the trick (I hope :)

@orklah
Copy link
Contributor

orklah commented Nov 1, 2022

Could you check both with PackageVersion? It will be easier to find in the future when we want to remove 4.x

@danog
Copy link
Contributor Author

danog commented Nov 1, 2022

Done!

@orklah orklah merged commit e610736 into psalm:master Nov 1, 2022
@orklah
Copy link
Contributor

orklah commented Nov 1, 2022

Thanks!

tcarrio pushed a commit to open-feature/php-sdk that referenced this pull request Dec 19, 2022
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
|
[psalm/plugin-phpunit](https://togithub.com/psalm/psalm-plugin-phpunit)
| require-dev | minor | `^0.17.0` -> `^0.18.0` |

---

### Release Notes

<details>
<summary>psalm/psalm-plugin-phpunit</summary>

###
[`v0.18.4`](https://togithub.com/psalm/psalm-plugin-phpunit/releases/tag/0.18.4)

[Compare
Source](https://togithub.com/psalm/psalm-plugin-phpunit/compare/0.18.3...0.18.4)

#### What's Changed

- Allow Psalm 5.0 by [@&#8203;ddeboer](https://togithub.com/ddeboer) in
[psalm/psalm-plugin-phpunit#127

#### New Contributors

- [@&#8203;ddeboer](https://togithub.com/ddeboer) made their first
contribution in
[psalm/psalm-plugin-phpunit#127

**Full Changelog**:
psalm/psalm-plugin-phpunit@0.18.3...0.18.4

###
[`v0.18.3`](https://togithub.com/psalm/psalm-plugin-phpunit/releases/tag/0.18.3):
Fix typo

[Compare
Source](https://togithub.com/psalm/psalm-plugin-phpunit/compare/0.18.2...0.18.3)

#### What's Changed

- Fix typo, it turns out $\_ is used later on as a ref parameter by
[@&#8203;danog](https://togithub.com/danog) in
[psalm/psalm-plugin-phpunit#126

**Full Changelog**:
psalm/psalm-plugin-phpunit@0.18.2...0.18.3

###
[`v0.18.2`](https://togithub.com/psalm/psalm-plugin-phpunit/releases/tag/0.18.2):
Fix version detection

[Compare
Source](https://togithub.com/psalm/psalm-plugin-phpunit/compare/0.18.1...0.18.2)

#### What's Changed

- Dumb version detection by [@&#8203;danog](https://togithub.com/danog)
in
[psalm/psalm-plugin-phpunit#125

**Full Changelog**:
psalm/psalm-plugin-phpunit@0.18.1...0.18.2

###
[`v0.18.1`](https://togithub.com/psalm/psalm-plugin-phpunit/releases/tag/0.18.1):
Allow using on 5.x-dev

[Compare
Source](https://togithub.com/psalm/psalm-plugin-phpunit/compare/0.18.0...0.18.1)

###
[`v0.18.0`](https://togithub.com/psalm/psalm-plugin-phpunit/releases/tag/0.18.0):
Compatibility release

[Compare
Source](https://togithub.com/psalm/psalm-plugin-phpunit/compare/0.17.0...0.18.0)

#### What's Changed

- \[composer.json] allow Psalm 5 beta by
[@&#8203;someniatko](https://togithub.com/someniatko) in
[psalm/psalm-plugin-phpunit#122
- Immutable refactoring by [@&#8203;danog](https://togithub.com/danog)
in
[psalm/psalm-plugin-phpunit#123

#### New Contributors

- [@&#8203;someniatko](https://togithub.com/someniatko) made their first
contribution in
[psalm/psalm-plugin-phpunit#122
- [@&#8203;danog](https://togithub.com/danog) made their first
contribution in
[psalm/psalm-plugin-phpunit#123

**Full Changelog**:
psalm/psalm-plugin-phpunit@0.17.0...0.18.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://app.renovatebot.com/dashboard#github/open-feature/php-sdk).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC42My4yIiwidXBkYXRlZEluVmVyIjoiMzQuNjMuMiJ9-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants