Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sometimes caret disappears on Chrome #22

Closed
brunokrebs opened this issue Jan 4, 2016 · 6 comments
Closed

Sometimes caret disappears on Chrome #22

brunokrebs opened this issue Jan 4, 2016 · 6 comments

Comments

@brunokrebs
Copy link
Collaborator

This happens quite frequently and it is annoying but looks like it is really easy to solve.

How to reproduce

Open the demo page, remove all content, write something and then click somewhere else in the page. After that click on the editor again and the caret is not shown, even though it is possible to keep editing the content.

Possible solution

This answer on stackoverflow's thread give a hint on how to solve this. By adding the following style to the iframe's document:

html, body {
    height:100%;
}

everything works as expected.

@brunokrebs
Copy link
Collaborator Author

Well, actually I've found a better solution, which is the same one implemented by CKEditor to the issue opened there. Check out the following merge on their repo.

I will make a pull request with my solution.

@psergus
Copy link
Owner

psergus commented Jan 5, 2016

@brunokrebs, thanks for much for helping man 👍

@psergus psergus closed this as completed Jan 5, 2016
@brunokrebs
Copy link
Collaborator Author

@psergus would you mind to release a patch with my fix?

@psergus
Copy link
Owner

psergus commented Jan 7, 2016

@brunokrebs, yeah, should be already in the master repo. Please check it out. Let me know if something not right.

@brunokrebs
Copy link
Collaborator Author

You are right, @psergus, my fix is in the master repo already, but there is no new patch (i.e. no git tag) with my fix.

I was going to tell you that you need to bump it with bower, but I just saw that bower.json has the wrong version. I'm going to fix it and send a pull request.

@psergus
Copy link
Owner

psergus commented Jan 10, 2016

ahh, you are 100% right. Yea, sends the request and I will merge with the
master.

On Sun, Jan 10, 2016 at 10:08 AM, Bruno Krebs notifications@github.com
wrote:

You are right, @psergus https://github.com/psergus, my fix is in the
master repo already, but there is no new patch (i.e. no git tag) with my
fix.

I was going to tell you that you need to bump it with bower, but I just
saw that bower.json
https://github.com/psergus/ngWYSIWYG/blob/master/bower.json#L3 has the
wrong version. I'm going to fix it and send a pull request.


Reply to this email directly or view it on GitHub
#22 (comment).

Best regards,
Sergey Petrenko

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants