Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: upgrade envoyproxy/protoc-gen-validate to v0.3.0-java #418

Conversation

zetaron
Copy link
Contributor

@zetaron zetaron commented Apr 20, 2020

This update resolves #414

The update is required due to a breaking changes in the validate.proto since its v0.0.14 release.

@CAFxX
Copy link

CAFxX commented Aug 18, 2020

@pseudomuto any chance to get this looked at? I'm running in the same issue. 🙏

note: in the meanwhile https://github.com/envoyproxy/protoc-gen-validate/releases/tag/v0.4.1 was also released

Copy link
Owner

@pseudomuto pseudomuto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM 👍

@pseudomuto pseudomuto merged commit f8b953d into pseudomuto:master Aug 18, 2020
@plaflamme
Copy link

@pseudomuto Thanks for merging this! Any chance we can get an official release with this fix included?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Envoyproxy validated fields not present in generated html (v.1.3.1)
4 participants