New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test on Python 3.9-dev #1393
Test on Python 3.9-dev #1393
Conversation
Thanks! The error looks like a CPython bug; I'll try to distill it into a bug report unless somebody else gets to it. |
Oh, good to find it :) @brettcannon will be happy, I was following his suggestion of testing dev versions! https://snarky.ca/how-to-use-your-project-travis-to-help-test-python-itself/ |
Posted in https://bugs.python.org/issue40397 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I might put a PR up to see if anyone else agrees.
@@ -27,6 +27,10 @@ matrix: | |||
python: 3.7 | |||
- name: "3.8" | |||
python: 3.8 | |||
- name: "3.9" | |||
python: 3.9-dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm more of a fan of nightly for failure allowed testing:
- python: nightly
allow_failures:
- python: nightly
Then we get signal on the net versions fixes sooner :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it so that nightly
and 3.9-dev
are the same thing at the moment? And at some point in the future, nightly
will be 3.10?
Sounds like a good idea to add it.
I'd suggest also keeping 3.9-dev
as a gating check which can fail the whole build, ie. not in allowed_failures
, to make sure new PRs pass on 3.9. (But only when the CPython bug is fixed and released.)
Python 3.9 is currently in alpha with a beta due in a couple of weeks (2020-05-18).
This PR tests
3.9-dev
on Travis CI, currently Python 3.9.0a6+.However, it's failing, so as a pre-release I put it in the
allow_failures
so it won't turn the whole CI red.The error is:
https://travis-ci.org/github/hugovk/black/jobs/684724917