Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test on Python 3.9-dev #1393

Merged
merged 2 commits into from
May 8, 2020
Merged

Test on Python 3.9-dev #1393

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
351a9bf
Test on Python 3.9-dev
hugovk May 8, 2020
7770935
Python 3.9 still in alpha, allow to fail
hugovk May 8, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 4 additions & 0 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,10 @@ matrix:
python: 3.7
- name: "3.8"
python: 3.8
- name: "3.9"
python: 3.9-dev
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm more of a fan of nightly for failure allowed testing:

    - python: nightly
  allow_failures:
    - python: nightly

Then we get signal on the net versions fixes sooner :)

Copy link
Contributor Author

@hugovk hugovk May 9, 2020 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it so that nightly and 3.9-dev are the same thing at the moment? And at some point in the future, nightly will be 3.10?

Sounds like a good idea to add it.

I'd suggest also keeping 3.9-dev as a gating check which can fail the whole build, ie. not in allowed_failures, to make sure new PRs pass on 3.9. (But only when the CPython bug is fixed and released.)

allow_failures:
- python: 3.9-dev
before_deploy:
- pip install pyinstaller
- pyinstaller --clean -F --add-data blib2to3/:blib2to3 black.py
Expand Down