Add json parameter #2258
Add json parameter #2258
Conversation
There was a problem hiding this comment.
This would get passed through with the kwargs, right, so I guess this is just so people know about the parameter?
requests/models.py
Outdated
There was a problem hiding this comment.
Working on changing that already. The problem is that the module json is imported at the top and needs to be used.
There was a problem hiding this comment.
Fixed by aliasing json_dumps = json.dumps at the top of the module. Not sure I like it, but apparently import semantics are such that requests.compat.json can't be imported from (e.g., you can't do from .compat.json import dumps). Can you think of a better solution to avoid the local variable/parameter from shadowing the top-level module name beyond doing from . import compat and then doing compat.json.dumps?
- Don't _ prefix json in prepare_body
- Don't initialize json to []
- Don't initialize json to {}
- Reorder parameters to PreparedRequest.prepare
- Remove extra parentheses
- Update docstring
|
@Lukasa @kevinburke care to take another look at this? |
|
LGTM |
|
omg I'm so excited ❤️ ✨ 🍰 🌹 🍰 ✨ ❤️ |
|
@willingc thank you so much for your hard work on this. 🍰 (Those emoji from @kennethreitz are for you ;)) |
|
Thank you @sigmavirus24 for your support and mentoring 🎸 🌅 🌲 , @Lukasa for the review 🐱 🐈 😸 , and @kennethreitz for the community atmosphere 📷 ✌️ 🎸 |
|
@willingc thank YOU, and you're welcome :) |
There was a problem hiding this comment.
Sorry I'm late to the party, was out - wouldn't this also change the meaning for anyone who creates a Request by hand, eg
params = {'date_created': '1-1-14'}
req = Request('GET', 'http://jsonip.com', {'User-Agent': 'foobar'}, None, {}, params)where now suddenly params is JSON data?
ghost
mentioned this pull request
5 participants
Closes #2025